Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-52189] FlowExecutionListener.onCreated #92

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

t-8ch
Copy link
Contributor

@t-8ch t-8ch commented Apr 25, 2019

This method is called after the FlowExecution has been created, but before it
is started. This allows to customize the FlowExecution earlier, especially a
GraphListener can be added that also receives the FlowStartNode.

Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions, but seems fine in general.

This method is called after the FlowExecution has been created, but before it
is started. This allows to customize the FlowExecution earlier, especially a
GraphListener can be added that also receives the FlowStartNode.
@t-8ch t-8ch force-pushed the flowexecutionlistener-oncreated branch from 9baeb89 to 721df0a Compare June 19, 2019 07:39
@t-8ch
Copy link
Contributor Author

t-8ch commented Jun 19, 2019

@dwnusbaum Thanks for the review. I used your recommendations (plus a few newlines)

@dwnusbaum dwnusbaum merged commit 8f1cc7a into jenkinsci:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants