-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-58084] Add StepListener #96
Conversation
* executed, including throwing an exception to cause the step to fail. | ||
*/ | ||
public interface StepListener extends ExtensionPoint { | ||
void newStep(@Nonnull Step step, @Nonnull StepContext context) throws Exception; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably benefit from a more descriptive method name, I just dashed this one off…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is very much a first draft. =)
Downstream of jenkinsci/workflow-api-plugin#96 Signed-off-by: Andrew Bayer <[email protected]>
Downstream of jenkinsci/workflow-api-plugin#96 Signed-off-by: Andrew Bayer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, added some minor comments about doc changes and the API signature.
src/main/java/org/jenkinsci/plugins/workflow/flow/StepListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/workflow/flow/StepListener.java
Outdated
Show resolved
Hide resolved
….java Co-Authored-By: Devin Nusbaum <[email protected]>
….java Co-Authored-By: Devin Nusbaum <[email protected]>
JENKINS-58084
(downstream in workflow-cps coming shortly)