Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that retry does not catch inner timeout #143

Closed
wants to merge 1 commit into from

Conversation

dduportal
Copy link
Contributor

As per https://issues.jenkins.io/browse/JENKINS-51454?focusedCommentId=381283&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-381283

this PR modifies the documentation for the retry block to mention that

retry(3) {
    timeout(XXX) {
    // steps
    }
}

does not behave as expected.

Ref. jenkins-infra/docker-jenkins-weeklyci#205 where we tried it, but we discovered that it never retries when the timeout is reached.

This commit can be safely reverted when #81 would be merged.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jglick jglick changed the title chore: Document that retry does not catch inner timeout Document that retry does not catch inner timeout Jun 1, 2021
@dwnusbaum
Copy link
Member

#144 is a proposal to make the snippet in the description behave as expected.

@dduportal dduportal closed this Oct 11, 2021
@dduportal dduportal deleted the patch-1 branch October 11, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants