Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing against workflow-cps 2.67 #67

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Testing against workflow-cps 2.67 #67

merged 3 commits into from
Apr 24, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 23, 2019

I needed a baseline to test jenkinsci/workflow-cps-plugin#211 and this plugin was still using a months-old version predating multiple security fixes.

@jglick jglick requested review from abayer and dwnusbaum April 23, 2019 19:26
dwnusbaum
dwnusbaum reviewed Apr 23, 2019
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a Findbugs error on the CI build:

[2019-04-23T19:39:53.447Z] [ERROR] Nullcheck of lease at line 152 of value previously dereferenced in org.jenkinsci.plugins.workflow.libs.SCMSourceRetriever.doRetrieve(String, boolean, SCM, FilePath, Run, TaskListener) [org.jenkinsci.plugins.workflow.libs.SCMSourceRetriever, org.jenkinsci.plugins.workflow.libs.SCMSourceRetriever] At SCMSourceRetriever.java:[line 152]Redundant null check at SCMSourceRetriever.java:[line 153] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE

Seems fine other than that.

dwnusbaum
dwnusbaum approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge assuming CI build passes. Looks like the SpotBugs issue is tracked as spotbugs/spotbugs#756.

@jglick
Copy link
Member Author

jglick commented Apr 23, 2019

Looks like an Azure mirror outage this time.

@jglick jglick closed this Apr 23, 2019
@jglick jglick reopened this Apr 23, 2019
@jglick jglick mentioned this pull request Apr 23, 2019
Merged
@dwnusbaum dwnusbaum merged commit 31a9874 into jenkinsci:master Apr 24, 2019
@jglick jglick deleted the deps branch April 24, 2019 13:56
jglick added a commit to jglick/workflow-cps-global-lib-plugin that referenced this pull request Apr 24, 2019
@jglick
Merge branch 'master' into CustomDescribableModel-JENKINS-44892
cdbcda1 
Resolved conflicts with jenkinsci#67.
@dwnusbaum dwnusbaum mentioned this pull request Jun 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

@abayer abayer Awaiting requested review from abayer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @dwnusbaum