Remove commons-lang3 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran a basic smoke test which seemed to work, the library was loaded: |
|
@timja Thanks for filing the PR! I think that normal cases should work fine, my main concern is if @jglick had some particular reason not to use |
jglick
approved these changes
Apr 9, 2020
To the extent I can recall now, I think I just did not realize it was available. |
jetersen
approved these changes
Apr 10, 2020
bitwiseman
approved these changes
Apr 10, 2020
dwnusbaum
approved these changes
Apr 13, 2020
| @@ -265,16 +263,10 @@ public AutoCompletionCandidates doAutoCompleteIdentifier(@AncestorInPath ItemGro | |||
| @Override public Object invokeMethod(String name, Object _args) { | |||
| Class<?> c = loadClass(prefix + clazz); | |||
| Object[] args = _args instanceof Object[] ? (Object[]) _args : new Object[] {_args}; // TODO why does Groovy not just pass an Object[] to begin with?! | |||
There was a problem hiding this comment.
nit: InvokerHelper handles this conversion internally via InvokerHelper.asArray, so I think this line could be removed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #93 (review)
@jglick @dwnusbaum @bitwiseman