Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save flowNodeStore.xml entries in order #255

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 18, 2024

After jenkinsci/workflow-cps-plugin#807 by @dwnusbaum I started poking through large build records captured by support-core and was frustrated by the semi-random order of flow nodes.

Before fix:

java.lang.AssertionError: 

Expected: is <[2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43]>
     but: was <[22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 10, 33, 11, 34, 12, 35, 13, 36, 14, 37, 15, 38, 16, 39, 17, 18, 19, 2, 3, 4, 5, 6, 7, 8, 9, 40, 41, 42, 20, 43, 21]>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at org.jenkinsci.plugins.workflow.support.storage.BulkFlowNodeStorageTest.orderOfEntries(BulkFlowNodeStorageTest.java:58)

@jglick jglick requested a review from a team as a code owner March 18, 2024 20:47
@jglick jglick enabled auto-merge March 18, 2024 21:00
@jglick jglick merged commit 7663695 into jenkinsci:master Mar 18, 2024
13 of 14 checks passed
@jglick jglick deleted the orderOfEntries branch March 18, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants