Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups can't be changed if there is a new device in the inbox #1437

Closed
grunes opened this issue Oct 4, 2021 · 12 comments · Fixed by #2886
Closed

groups can't be changed if there is a new device in the inbox #1437

grunes opened this issue Oct 4, 2021 · 12 comments · Fixed by #2886
Labels
🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component

Comments

@grunes
Copy link

grunes commented Oct 4, 2021

Describe the bug
It's not longer possible to edit groups if there is a new device in the inbox. Web-UI is freezing during device configuration. Seams to be a re-bug of #945

Steps to reproduce the behavior

  1. Add a new device, must be in the inbox ("Posteingang")
  2. Edit a group (e.g. remove a device)
  3. press OK button

Expected behavior
group should be saved without the deleted device.

Screenshots
image

System information:

  • RaspberryMatic Version: 3.59.6.20210911
  • Used Hardware: Asus Tinker Board S
  • Used HomeMatic RF-Module: RPI-RF-MOD

Additional context
after removing the new device from the inbox, the group can be saved as expected.

@jens-maus jens-maus added 🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component labels Oct 5, 2021
@jens-maus
Copy link
Owner

Usual question: @Baxxy13 @jp112sdl can you reproduce this issue? My feeling is that this might be some internal issue in the web parts in HMIPServer which we don't have access to in the end. Would be great if someone can try to reproduce it.

@jp112sdl
Copy link
Contributor

jp112sdl commented Oct 5, 2021

I cannot test adding/removing devices to an HmIP-group, because I have no HmIP devices.

But with having a BidCos device in the inbox, I can create/delete/edit a "classic HM" group without any error and I can create/delete an empty HmIP-group, too.

@Baxxy13
Copy link
Contributor

Baxxy13 commented Oct 5, 2021

I can reproduce this and maybe found something.
The teached in device (HmIP-SCI in this case) which is still located in the inbox...
SCI in Posteingang

... will showed as an addable device, but without icon and an unconventional name.
IP-GRUPPE bei Gerät im Posteingang_A

Adding this strange device or any other possible device ends up in the rotating circle.
IP-GRUPPE bei Gerät im Posteingang_B

Sorry für's holprige Englisch. Darf gerne korrigiert werden.

@grunes
Copy link
Author

grunes commented Oct 6, 2021

We even can switch to German!

@stale
Copy link

stale bot commented Jan 28, 2022

Thanks for your contribution!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of RaspberryMatic and tell us. Also check that all relevant details,


Vielen Dank für die Unterstützung!
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüfen Sie, ob das Problem auch in der aktuellsten Version von RaspberryMatic noch relevant ist, und teilen Sie uns dies mit. Überprüfen Sie auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind oder aktualisiert werden müssen.

@stale stale bot added the 👎 wontfix This will not be worked on label Jan 28, 2022
@grunes
Copy link
Author

grunes commented Jan 31, 2022

any updates?

@stale stale bot removed the 👎 wontfix This will not be worked on label Jan 31, 2022
@stale
Copy link

stale bot commented May 2, 2022

Thanks for your contribution!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of RaspberryMatic and tell us. Also check that all relevant details,


Vielen Dank für die Unterstützung!
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüfen Sie, ob das Problem auch in der aktuellsten Version von RaspberryMatic noch relevant ist, und teilen Sie uns dies mit. Überprüfen Sie auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind oder aktualisiert werden müssen.

@stale stale bot added the 🧊 stale Ticket is in a stale state (about to be closed) label May 2, 2022
@jens-maus jens-maus removed the 🧊 stale Ticket is in a stale state (about to be closed) label May 2, 2022
@jens-maus jens-maus added this to the future release milestone May 2, 2022
@rene-re
Copy link

rene-re commented Dec 22, 2022

  • I cannot add any devices to a group.
  • Stuck with "Gruppe wird gespeichert"
  • Inbox is empty
  • Running version 3.65.11.20221218

image

@Baxxy13
Copy link
Contributor

Baxxy13 commented Dec 22, 2022

Known problem in the actual RaspberryMatic.
Solutions:

  • Downgrade
  • use actual Nightly Snapshaot
  • repair it "manually" --> see here

@jens-maus
Copy link
Owner

You forgot to mention also: Read carefully through an existing ticket/issue before hijacking it because this issue here is substantially different because it relates to the point that adding groups is not possible if there is a device waiting in the inbox!

@rene-re
Copy link

rene-re commented Dec 22, 2022

Thanks for the swift response and help. I also noted your feedback that my response is not identical - should it might provide additional context. Thanks! @jens-maus @Baxxy13

@sikraemer
Copy link

sikraemer commented Jan 29, 2024

Hi,

I ran into this issue today. Same error message as in the original post.
My setup is running on version 3.73.9.20231130 on a RPi4 through the HomeAssistant Addon.

I could pinpoint the error to occur here.
Generally when devices are added to the assignableDevices of the viewModel here, the device member is not set if the device is still in the inbox.

I am not sure if the problem is caused by the response caused by either of these 3.
Each of them can be adjusted to fix the problem.

  • the API response from /pages/jpages/group/suitableGroupMembers - since the devices don't seem to be suitable
  • the part that adapts the json response into the assignableDevices of the viewModel
  • the part when the remaining assignableDevices are marked as not in the group without checking if the device member even exists

Any input on the direction of how the fix should be applied would be appreciated.

@jens-maus @grunes

jp112sdl pushed a commit to jp112sdl/RaspberryMatic that referenced this issue Oct 31, 2024
@jens-maus jens-maus linked a pull request Nov 1, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants