Support Rails 7 #100
Support Rails 7 #100
Conversation
erikaxel
force-pushed
the
master
branch
6 times, most recently
from
646b52d to
2465f71
Compare
|
Hi, this should now be ready for merge. Im sorry if my repeated tries at getting Github Actions to work pinged you unnecessarily. |
|
@jenseng If you could merge this I would be happy to see if I can add testing support for more recent Rubies such as 3.0 and 3.1 as well. |
|
@erikaxel thanks for your work. Is there any news on this? It would be nice to support rails 7 and ruby 3.1 |
| @@ -31,6 +31,17 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| ruby: ['2.5', '2.7'] | |||
There was a problem hiding this comment.
It probably wouldn't hurt to add 3.1/3.2 here as well since those are preferred for Rails 7. Anything to get Rails 7 support first though.
There was a problem hiding this comment.
I think it makes sense to add support for 3.0 and 3.1 as a separate PR? I'm happy to do that as soon as this is merged. We have used both 3.0 and 3.1 with hair_trigger so that should be no problem
There was a problem hiding this comment.
That makes sense to me, especially if there's a chance adding those to this PR delays getting it merged in.
There was a problem hiding this comment.
@erikaxel could you create a PR for rubies 3.0 and 3.1?
|
Hey, migrating to Rails 7 as well, this PR is very welcome 👍 |
|
@joeyparis are you the current maintainer of the repo? |
|
@AlfonsoUceda unfortunately not |
|
@jenseng could you take a look? |
|
Thanks @erikaxel! Sorry for the slow turnaround, I'll push out a new version in a bit |
|
v0.2.25 should support rails 7 |
|
Thank you @jenseng |
Rails 7 only supports Ruby 2.7+, so this commit also adds support for only running tests on a subset of different Ruby versions pr supported Rails version.