Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver/QDac_channels #3

Conversation

WilliamHPNielsen
Copy link

@WilliamHPNielsen WilliamHPNielsen commented Jun 13, 2017

Add a channelised QDac Driver

Changes proposed in this pull request:

  • Add a driver for a channelised QDac
  • Make ChannelList take default MultiChannelInstrumentParameter subclasses as input

Still missing:

  • An example notebook

@jenshnielsen

Make the paramclass returned by __getattr__ be customisable.
Add a channelised driver for the QDac. This requires changing the base code
for channels a bit to allow for custom MultiChannelInstrumentParameter
subclasses.
output = tuple(chan.parameters[self._param_name].get_latest()
for chan in self._channels)

# call _instrument.get_status() once and then get_latest
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant comment?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure is.

@jenshnielsen jenshnielsen merged commit eb5e700 into jenshnielsen:feat/channelization_with_array Jun 14, 2017
jenshnielsen pushed a commit that referenced this pull request Jun 11, 2018
jenshnielsen pushed a commit that referenced this pull request Mar 1, 2019
Addition: Added pulse waveform to waveforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants