fix: allocated_buffers and set_base_setpoints #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
pushed a commit
that referenced
this pull request
Jun 11, 2018
astafan8
pushed a commit
that referenced
this pull request
Apr 12, 2019
jenshnielsen
pushed a commit
that referenced
this pull request
Dec 5, 2019
…cycle_parameter Feature/rigol dg1062/adding duty cycle parameter
jenshnielsen
pushed a commit
that referenced
this pull request
May 12, 2021
Add Delegate module to the api docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the number of allocated buffers such that only 2 buffers are allocated even if there are more than 2 buffers per acquisition (because it switches between which buffer takes the data while the other 'offloads' and does not need more than this even if many buffers are taken). It also fixes the set_base_setpoints such that it does not break if you set values to 0 (and rather just checks if they are None or not)
@jenshnielsen