feat: move private file .upgraded into .venv/ folder #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behnazh
requested changes
Jul 7, 2022
behnazh
reviewed
Jul 7, 2022
Commit aa64af7. |
jenstroeger
force-pushed
the
move-upgraded
branch
from
ef9af08 to
3e29176
Compare
|
Commit 3e29176 adds a check that compares the With that in mind, I think this PR becomes more of a |
Yes, sounds good. |
jenstroeger
changed the title
behnazh
reviewed
Jul 10, 2022
This was referenced Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #238 #240
And while at it, I renamed the file to
upgraded-onand added a timestamp:In order to make this work in CI, I also changed the Actions to create a virtual environment (see also actions/setup-python#359 (comment)) such that our Actions workflows now operate on virtual environments using the complete Makefile 👍🏼