Skip to content
This repository has been archived by the owner on Jan 16, 2019. It is now read-only.

Remove hard dependency on RxJava #4

Closed
jenzz opened this issue May 12, 2016 · 2 comments
Closed

Remove hard dependency on RxJava #4

jenzz opened this issue May 12, 2016 · 2 comments

Comments

@jenzz
Copy link
Owner

jenzz commented May 12, 2016

Even though it is pretty much standard (?) in Android world nowadays and the name of the library implies it,
this library should probably not depend on RxJava.

Instead an additional, reactive adapter could be provided, e.g. com.jenzz:appstate-rx:2.0.0

@lordcodes
Copy link

Another possibility could be a provided dependency. That way if you call .subscribe() without having the RxJava dependency it will crash.
This is similar to how Retrofit 1 worked, where it could return Observables without having a dependency on RxJava.

@jenzz jenzz added this to the 2.0.0 milestone Nov 23, 2016
@jenzz jenzz removed this from the 2.0.0 milestone Dec 1, 2016
@jenzz
Copy link
Owner Author

jenzz commented Apr 11, 2017

- Done via 3ea68fe -

@jenzz jenzz closed this as completed Apr 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants