Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer canvas creation #56

Merged
merged 7 commits into from
Aug 1, 2023
Merged

defer canvas creation #56

merged 7 commits into from
Aug 1, 2023

Conversation

jerch
Copy link
Owner

@jerch jerch commented Jul 11, 2023

Should fix #55.

@jerch
Copy link
Owner Author

jerch commented Jul 11, 2023

@Tyriar This PR should remove most of the nasty init burden and initialize the canvas & the placeholder lazy. This is not the nicest PR, but gets the job done in local tests. For normal terminal usage w'o any image sequences there should not be any image canvas anymore on the DOM.

Not quite sure how you can test it without going through the whole build burden (the bootstrapping is quite cumbersome I admit) - I can do a local bundle and put the file in a gist for testing, if you want.

Edit: The changes are not that much, thus I dont mind transferring them myself.

@jerch
Copy link
Owner Author

jerch commented Aug 1, 2023

@Tyriar The Pr is done. The changes got bigger than anticipated 😸 , whatever - gonna do a last patch release for these here, and apply the code changes in the base repo PR afterwards.

@jerch jerch merged commit 1e1c8bb into master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazily create the canvas element
2 participants