Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example with react-navigation #13

Closed
wants to merge 2 commits into from
Closed

Conversation

guizmo
Copy link

@guizmo guizmo commented Dec 23, 2018

This example is with react-navigation but it doesn't wrap the modal inside the router.

P.S: there is a "settimeout" in the destroy function because of a warning thrown while un-mounting the component... maybe there is a better way

@jeremybarbet
Copy link
Owner

jeremybarbet commented Dec 28, 2018

Thanks for the pull request!

I won't merge this pull request, but I'm using your code to move it on my branch since I'm using typescript everywhere and try to share all the modals codes between the different examples.

The only difference with your code is I won't use mobx, I would like an example as dependency-free as possible. Anyway thanks for the contribution, moving the modal around the app navigator is probably the best way to do it 👍🏻

Cf: There is still a discussion open on the react-navigation repository to find the best way to handle overlays: react-navigation/rfcs#15

@jeremybarbet
Copy link
Owner

I just merged the pull request with all the examples. Thanks for the help 👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants