-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use Node 18 #360
chore: Use Node 18 #360
Conversation
- Required upgrade to node-sass 8.0.0 - Required --openssl-legacy-provider - See: https://nodejs.org/en/blog/release/v17.0.0/#openssl-3-0 - See: https://stackoverflow.com/a/69699772
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
- name: Checkout repository | ||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only meaningful change in this file.
everything seems to be working for me except tests. i tried completely removing
it doesn't seem to be an issue in github CI, but i can't seem to get past it on my machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test failures was my fault! looks good to me 😄
What this PR does
This PR eliminates the warnings produced by GitHub Actions about use of deprecated APIs:
The solution for this was ultimately to upgrade the GitHub Actions we're using. In trying to resolve this, I updated a number of things that turned out not to be necessary, but are worth doing regardless. Rather than roll them back, this is a good opportunity to update some of our aging project infrastructure. As such, this PR includes:
--openssl-legacy-provider
where necessarynode-sass
8npm ci
flags with an.npmrc
fileHow this change can be validated
Run
npm ci
locally, install Node 18 and make sure the important scripts work (test
,start
,build
, and maybe spot-check a few others).Additional information
I will have to update our Vercel configuration with similar settings once this is merged.