Add :no-umbrella config option
#481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for contributing this, but having it as a CLI option seems a little bit inconvenient since it is a fact about the project configuration that will never change between invocations. I think it might be better to have it as a configuration option specified in the |
In some cases you may want to place the `lockfile` in a parent folder without having an umbrella. With this extra option you avoid compilation at the parent folder which will fail since in such cases there is no `mix.exs`. If this flag is not set then the behaviour remains unchanged.
|
@jeremyjh you are right, updated the PR accordingly |
jeremyjh
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases you may want to place the
lockfilein a parent folder without having an umbrella. With this extra option you avoid compilation at the parent folder which will fail since in such cases there is nomix.exs. If this flag is not set then the behaviour remains unchanged.