Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FP]: False positives for splunk-library-javalogging #7339

Closed
Subrhamanya opened this issue Jan 22, 2025 · 19 comments
Closed

[FP]: False positives for splunk-library-javalogging #7339

Subrhamanya opened this issue Jan 22, 2025 · 19 comments
Labels
FP Report maven changes to the maven plugin

Comments

@Subrhamanya
Copy link

Subrhamanya commented Jan 22, 2025

Package URl

pkg:maven/com.splunk.logging/[email protected]

CPE

cpe:2.3:a:splunk:splunk:*:*:*:*:*:*:*:*

CVE

CVE-2022-32158

ODC Integration

{"label" => "Maven Plugin"}

ODC Version

12.0.0

Description

There are too many false positive CVEs reported against splunk-library-javalogging. These CVEs should have been reported to splunk application rather than this jar.

Previous issue raised: (It has all CVE list. Sharing single CVE above)

#7242

CPE id: cpe:2.3:a:splunk:splunk::::::::

cc: @chadlwilson @jeremylong

Copy link
Contributor

Error parsing package url: https://mvnrepository.com/artifact/com.splunk.logging/splunk-library-javalogging/1.8.0.

Error: Error: Invalid purl: missing required "pkg" scheme component

Please correct the package URL - consider copying the package url from the HTML report.

Copy link
Contributor

Failed to automatically evaluate the false positive. See: https://github.com/jeremylong/DependencyCheck/actions/runs/12901598825

Copy link
Contributor

Error parsing package url: https://mvnrepository.com/artifact/com.splunk.logging/splunk-library-javalogging/1.8.0.

Error: Error: Invalid purl: missing required "pkg" scheme component

Please correct the package URL - consider copying the package url from the HTML report.

Copy link
Contributor

Failed to automatically evaluate the false positive. See: https://github.com/jeremylong/DependencyCheck/actions/runs/12901614690

Copy link
Contributor

Failed to automatically evaluate the false positive. See: https://github.com/jeremylong/DependencyCheck/actions/runs/12901638649

Copy link
Contributor

Failed to automatically evaluate the false positive. See: https://github.com/jeremylong/DependencyCheck/actions/runs/12901679688

Copy link
Contributor

Failed to automatically evaluate the false positive. See: https://github.com/jeremylong/DependencyCheck/actions/runs/12901761925

@chadlwilson
Copy link
Contributor

Hi @Subrhamanya - can you make a (useless) edit to the description again? The automation was broken before and didn't run, but it's hopefully fixed now.

Copy link
Contributor

Failed to automatically evaluate the false positive. See: https://github.com/jeremylong/DependencyCheck/actions/runs/12910055869

@Subrhamanya
Copy link
Author

Subrhamanya commented Jan 22, 2025

@chadlwilson It failed again with Could not find artifact com.splunk.logging:splunk-library-javalogging:jar:1.11.8 in maven-central

https://mvnrepository.com/artifact/com.splunk.logging/splunk-library-javalogging/1.11.8

@chadlwilson
Copy link
Contributor

It looks like it's not published to Maven Central. Do you get it from Splunk's repo, e.g https://splunk.jfrog.io/splunk/ext-releases-local/

@Subrhamanya
Copy link
Author

Subrhamanya commented Jan 22, 2025

@chadlwilson It's available in maven. I have attached the link above.

https://mvnrepository.com/artifact/com.splunk.logging/splunk-library-javalogging/1.11.8

Image

@chadlwilson
Copy link
Contributor

chadlwilson commented Jan 22, 2025

"Mvnrepository" is just a custom indexing website run by a single person. It is not Maven Central and not official, and indexes artifacts from many different repositories.

In this case it's a custom repository run by Splunk; I am asking if you are also retrieving the artifact in your builds from the custom Splunk repository. That's why the automation fails.

@Subrhamanya
Copy link
Author

Ahh ok got it. Yes I am also getting it from there..

@chadlwilson
Copy link
Contributor

See #7344 - that should unblock this.

We can always create a manual suppression, but much easier to fix the automation for future in case there are issues with other Splunk artifacts.

Copy link
Contributor

Failed to automatically evaluate the false positive. See: https://github.com/jeremylong/DependencyCheck/actions/runs/12910055869

Copy link
Contributor

Maven Coordinates

<dependency>
   <groupId>com.splunk.logging</groupId>
   <artifactId>splunk-library-javalogging</artifactId>
   <version>1.11.8</version>
</dependency>

Suppression rule:

<suppress base="true">
   <notes><![CDATA[
   FP per issue #7339
   ]]></notes>
   <packageUrl regex="true">^pkg:maven/com\.splunk\.logging/splunk-library-javalogging@.*$</packageUrl>
   <cpe>cpe:/a:splunk:splunk</cpe>
</suppress>

Link to test results: https://github.com/jeremylong/DependencyCheck/actions/runs/12919768630

@github-actions github-actions bot added the maven changes to the maven plugin label Jan 23, 2025
@chadlwilson
Copy link
Contributor

Approved

Copy link
Contributor

Suppress rule has been added to the generatedSuppressions branch.

github-actions bot added a commit that referenced this issue Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FP Report maven changes to the maven plugin
Projects
None yet
Development

No branches or pull requests

2 participants