Implementation of the new database schema for Oracle database #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cpeId Comment out the user/schema provisioning part and current schema selection. Those are typically pre-arranged by the DBA so should not typically be used in schema provisioning on Oracle.
…ate to insert identical records
…for update_vulnerability
|
@aikebah thank you for the PR! |
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #2755
Description of Change
Updated the Oracle initialization script and custom queries to match up with the new database layout of v6
Optimized querying Oracle by making larger fetches than by default to more closely match the other DBMSes that fetch ALL results directly into the ResultSet.
Have test cases been added to cover the new functionality?
No, not feasible as there is no Oracle DB to run the testcases against.
Some manual tests run with various projects to compare the vulnerabilities output between them and a manual comparison of post-initial load counts for all tables between PostgreSQL and Oracle to make sure both import the same number of records for each.