Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4671 #4688

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Fix #4671 #4688

merged 2 commits into from
Aug 18, 2022

Conversation

marcelstoer
Copy link
Contributor

@marcelstoer marcelstoer commented Jul 21, 2022

Fixes Issue

#4670, #4671, #4677, #4690

Description of Change

Suppress all CVEs filed against those Python pet projects as per github/securitylab#669 (comment). As the discussion in #4671 showed we will likely not succeed suppressing the CVEs surgically i.e. only those that really really cause conflict -> suppress'em all.

@boring-cyborg boring-cyborg bot added the core changes to core label Jul 21, 2022
@marcelstoer
Copy link
Contributor Author

Anything missing here? I'd like to wait with rebasing until it's its turn to get merged to avoid having to do that over and over again.

@OrangeDog
Copy link
Contributor

Rather than suppressing every individual CVE (including future ones), wouldn't it be better to suppress the CPE?

@marcelstoer
Copy link
Contributor Author

the CPE

There's as many CPEs as CVEs involved here. AFAIU suppressing one isn't better than the other but I'd happy to hear arguments that prove me wrong. With github/securitylab#669 (comment) @skavanagh went to great length to document that pretty much every one of those CVEs is pointless.

@OrangeDog
Copy link
Contributor

There's as many CPEs as CVEs involved here

Ah, my mistake. I though they had more in common than just _project.

@marcelstoer
Copy link
Contributor Author

I am interested in finding out whether the maintainers @jeremylong and @aikebah are planning on eventually merging this or whether I should close it.

@jeremylong
Copy link
Owner

Yes - I will likely be merging this before the next release. I haven't had as much time to focus on ODC as I have in the past due to a new job and needing to ramp up on a new platform, etc.

I've been considering several things with this event and will likely add some stories for the 8.0.0 release. Possibly creating a suppression file hosted on GitHub that will be able to be updated faster then the packaged release - so we can add suppressions to the hosted file and suppress things like this for a broader community in-between full releases. This would also including improving the issue-ops around false positives to assist in updating the hosted suppression file...

@marcelstoer
Copy link
Contributor Author

marcelstoer commented Aug 2, 2022

creating a suppression file hosted on GitHub that will be able to be updated faster then the packaged release

I can imagine this would certainly be very welcome by this community.

@jeremylong jeremylong added this to the 7.1.2 milestone Aug 17, 2022
@jeremylong jeremylong merged commit 91e1fb2 into jeremylong:main Aug 18, 2022
@marcelstoer marcelstoer deleted the fix/4671 branch August 18, 2022 11:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core changes to core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants