Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate entries for CISA #5332

Merged
merged 2 commits into from
Jan 17, 2023
Merged

fix: remove duplicate entries for CISA #5332

merged 2 commits into from
Jan 17, 2023

Conversation

strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Jan 17, 2023 •
edited
Loading

Fixes Issue

#5310 (very likely) as well as dependency-check/dependency-check-sonar-plugin#748

Description of Change

Duplicate entries for CISA cause parsers to fail, e.g. Jenkins Warnings NG Plugin parsing the JSON reports:

12:50:35  [Dependency Check] [-ERROR-] Parsing of file 'dependency-check-report.json' failed due to an exception:
12:50:35  [Dependency Check] [-ERROR-] org.json.JSONException: Duplicate key "CISA" at 1127 [character 1128 line 1]
12:50:35  [Dependency Check] [-ERROR-] 	at org.json.JSONTokener.syntaxError(JSONTokener.java:501)
12:50:35  [Dependency Check] [-ERROR-] 	at org.json.JSONObject.<init>(JSONObject.java:242)
12:50:35  [Dependency Check] [-ERROR-] 	at org.json.JSONTokener.nextValue(JSONTokener.java:418)
12:50:35  [Dependency Check] [-ERROR-] 	at org.json.JSONObject.<init>(JSONObject.java:245)
12:50:35  [Dependency Check] [-ERROR-] 	at org.json.JSONTokener.nextValue(JSONTokener.java:418)
12:50:35  [Dependency Check] [-ERROR-] 	at org.json.JSONObject.<init>(JSONObject.java:245)
12:50:35  [Dependency Check] [-ERROR-] 	at org.json.JSONTokener.nextValue(JSONTokener.java:418)
12:50:35  [Dependency Check] [-ERROR-] 	at edu.hm.hafner.analysis.parser.JsonIssueParser.parse(JsonIssueParser.java:29)
12:50:35  [Dependency Check] [-ERROR-]  [wrapped] edu.hm.hafner.analysis.ParsingException: Exception occurred during parsing
12:50:35  JSONException: Duplicate key "CISA" at 1127 [character 1128 line 1]
12:50:35  org.json.JSONException: Duplicate key "CISA" at 1127 [character 1128 line 1]
12:50:35  	at org.json.JSONTokener.syntaxError(JSONTokener.java:501)
12:50:35  	at org.json.JSONObject.<init>(JSONObject.java:242)
12:50:35  	at org.json.JSONTokener.nextValue(JSONTokener.java:418)
12:50:35  	at org.json.JSONObject.<init>(JSONObject.java:245)
12:50:35  	at org.json.JSONTokener.nextValue(JSONTokener.java:418)
12:50:35  	at org.json.JSONObject.<init>(JSONObject.java:245)
12:50:35  	at org.json.JSONTokener.nextValue(JSONTokener.java:418)
12:50:35  	at edu.hm.hafner.analysis.parser.JsonIssueParser.parse(JsonIssueParser.java:29)
12:50:35  	at edu.hm.hafner.analysis.IssueParser.parseFile(IssueParser.java:48)
12:50:35  	at io.jenkins.plugins.analysis.core.model.IssueReportScanner.processFile(IssueReportScanner.java:50)
12:50:35  	at io.jenkins.plugins.util.AgentFileVisitor.scanFiles(AgentFileVisitor.java:114)
12:50:35  	at io.jenkins.plugins.util.AgentFileVisitor.invoke(AgentFileVisitor.java:93)
12:50:35  	at io.jenkins.plugins.util.AgentFileVisitor.invoke(AgentFileVisitor.java:39)
12:50:35  	at hudson.FilePath.act(FilePath.java:1192)
12:50:35  	at hudson.FilePath.act(FilePath.java:1175)
12:50:35  	at io.jenkins.plugins.analysis.core.model.ReportScanningTool.scanInWorkspace(ReportScanningTool.java:168)
12:50:35  	at io.jenkins.plugins.analysis.core.model.ReportScanningTool.scan(ReportScanningTool.java:149)
12:50:35  	at io.jenkins.plugins.analysis.core.model.ReportScanningTool.scan(ReportScanningTool.java:133)
12:50:35  	at io.jenkins.plugins.analysis.core.steps.IssuesScanner.scan(IssuesScanner.java:104)
12:50:35  	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.scanWithTool(IssuesRecorder.java:811)
12:50:35  	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.record(IssuesRecorder.java:775)
12:50:35  	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.perform(IssuesRecorder.java:743)
12:50:35  	at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:1159)
12:50:35  	at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:1115)
12:50:35  	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
12:50:35  	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
12:50:35  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
12:50:35  	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
12:50:35  	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
12:50:35  	at java.base/java.lang.Thread.run(Thread.java:829)
12:50:35

Have test cases been added to cover the new functionality?

no

@boring-cyborg boring-cyborg bot added the core changes to core label Jan 17, 2023
@strangelookingnerd strangelookingnerd changed the title Remove duplicate entries for CISA fix: remove duplicate entries for CISA Jan 17, 2023
aikebah
aikebah approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... thanks for the PR

@aikebah aikebah added this to the 8.0.1 milestone Jan 17, 2023
@aikebah aikebah merged commit be9719f into jeremylong:main Jan 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aikebah aikebah aikebah approved these changes

Assignees
No one assigned
Labels
core changes to core
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@strangelookingnerd @aikebah