Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion in pinterest/ktlint#1434 (comment) I understood overriding an
.editorConfig
property viauserData
parameter won't be supported.According to pinterest/ktlint#1442 passing
indent_size
will result in a runtime exception. Regardless if this lands in current form, in context of the discussion from previous PR - I'm proposing to remove theindentSize
property from Kotlinter's extension.Regardless of how the future of ktlint will look like, I think such change makes sense:
a)
.editorconfig
should be the preferred way of setting the indent_size parameter, mainly because it integrates with IntelliJ based IDEs.b) it's less code to maintain 😛
The recommended migration path which probably should be mentioned in release notes is to replace
kotlinter.indentSize
with the following entry in{project_root}/.editorconfig
: