-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3: NFT (Image Tracking) + clean code + doc enhancement #742
Conversation
I started to remove aruco in small pieces, in this way is easier to identify breaking changes. |
is all the tango/aruco code removed? |
…jsartoolkit5 version
577f15b
to
2aa321c
Compare
Not completely but it will be soon. |
aruco code is completely removed, and testing examples are working correctly, ready to add NFT! |
In the nft.html threejs example the NFT marker is tracked but i can not see the Flamingo model. We need to check this... |
I can see that there are chunks of aruco code in threex-artoolkitcontext-nft.js to be removed and maybe in other parts. |
Ok, first it's better to remove ALL aruco (you can search for 'aruco' and 'tango' strings in the project) and then we can try to add NFT.html. I can help with adding it. |
I hope to work on it this afternoon ! |
With the lastest commit 97be36b The Flamingo model is shown onto the NFT marker! Actually pattern marker (threejs and aframe) and NFT marker with threejs both works toghether!! Next step is to re-add NFT to aframe.... we are very close really to a release. 😄 |
…me. re-added nft examples for aframe. all working.
This is it. We think to have reached a good release. We are finishing tests and then we will prepare several documentation enhancement. Should not take too much. This will solve also: |
I will manually close all related issues. The new v3 with Image Tracking will be available on the new AR.js repository, under AR.js organization. I will close this PR and as soon as the v3 is ready, I will make a redirect using the principal Readme on this repository. Thank you all. |
What kind of change does this PR introduce?
From #674 (comment) #674 and #705
This PR want to add NFT feature from artoolkitx/jsartoolkit5 and also other changes/improvements
🖼 This will eventually make AR.js capable of detect and track 2D images.
https://twitter.com/nicolocarp/status/1204841439160684549
Could be raise some bugs and incompatibilties between the code.
Can it be referenced to an Issue? If so what is the issue # ?
From jsartoolkit5 repo: PR kalwalt/jsartoolkit5#1
From AR.js issues:
also, a repo cleaning will help for: #433
and also: #722
How can we test it?
Just test the examples and tell us what happens...
Summary
see the other PR:
#722
#740
Does this PR introduce a breaking change?
Current repository will continue to be up, with marker + gps support.
A new repository will be created on AR.js new organization, that will feature two libraries:
Because of incompatibility between markers and NFT.
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Other information
I uploaded the new jsartookit5 libs and build the AR.js libs with makefile.
Progress