Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flags in prerequisites setup script #19

Closed
ruben-ayrapetyan opened this issue May 6, 2015 · 4 comments
Closed

Make flags in prerequisites setup script #19

ruben-ayrapetyan opened this issue May 6, 2015 · 4 comments
Assignees
Labels
enhancement An improvement infrastructure Related to GH Actions or the tested targets minor

Comments

@ruben-ayrapetyan
Copy link
Contributor

Hello.

Currently, prerequisites.sh uses 'make -j' to build cppcheck and vera++.
This can be too resource consuming.

To give control about the make options, we can pass "-j" flag in make command line only if it is passed to make instance, calling the script (MAKEFLAGS environment variable, created by make, can be used for this).

@ruben-ayrapetyan ruben-ayrapetyan changed the title Prerequisites script issues Make flags in prerequisites setup script May 6, 2015
@ILyoan
Copy link
Contributor

ILyoan commented May 6, 2015

By the way.
Why do we have to build vera++ by ourselves?
Is there a problem using vera++ distribution package?

@ruben-ayrapetyan
Copy link
Contributor Author

Actually, may be manual build of vera++ is unnecessary.

There is also distribution package for cppcheck in Ubuntu.
The issue with it are changes between versions.
Some false positives can appear in new versions, making precommit pass in one environment, and not - in another. Because of this, we've fixed cppcheck version by building necessary version manually, with other prerequisites.

Maybe, there are no similar cross-version issues with vera++. In the case, we could use distribution package.

@LaszloLango
Copy link
Contributor

I think the manual build of vera++ is totally unnecessary. This should be optional or at least should be checked if it is already installed or not.

@galpeter
Copy link
Contributor

In Ubuntu (from trusty to vivi) the vera++ package has the 1.2.1 version and the same version is in the prerequisites script.

@sand1k sand1k added enhancement An improvement infrastructure Related to GH Actions or the tested targets minor labels May 13, 2015
@egavrin egavrin added this to the Core ECMA features milestone Jun 5, 2015
sand1k pushed a commit to sand1k/jerryscript that referenced this issue Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement infrastructure Related to GH Actions or the tested targets minor
Projects
None yet
Development

No branches or pull requests

6 participants