Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge eval_dev branch to master #21

Closed
chunseoklee opened this issue May 7, 2015 · 3 comments
Closed

Merge eval_dev branch to master #21

chunseoklee opened this issue May 7, 2015 · 3 comments

Comments

@chunseoklee
Copy link
Contributor

'require' function in iotjs need eval feature which is not supported by current jerryscript/master branch. Thus, eval_dev should be merged into master.
@ruben-ayrapetyan
Copy link
Contributor

The eval_dev branch contains temporary implementation of eval, prepared because eval functionality is necessary for iotjs development.
The branch isn't supposed to be merged into master.

We are currently working on another, comprehensive eval implementation, that would be merged into master.
Until new implementation is done, please, use the eval_dev branch.

If it is necessary, we could rebase eval_dev on current master branch.

@chunseoklee
Copy link
Contributor Author

OK.
Until eval implementation is done, I will work on eval_dev branch.
Please rebase eval_dev.

@ruben-ayrapetyan
Copy link
Contributor

eval_dev is rebased.
Please, check.

@sand1k sand1k closed this as completed May 13, 2015
sand1k pushed a commit to sand1k/jerryscript that referenced this issue Dec 1, 2015
@ruben-ayrapetyan
Merge pull request jerryscript-project#21 from ruben-ayrapetyan/exper…

Verified

This commit was signed with the committer’s verified signature.
mcollina Matteo Collina
GPG key ID: 818674489FBC127E
Verified
Learn about vigilant mode
d1ff9d1 
…iments-dev

Experiments dev
@corporateshill corporateshill mentioned this issue Aug 17, 2017
Closed
@zhunki zhunki mentioned this issue Mar 11, 2018
Closed
grgustaf added a commit to grgustaf/jerryscript that referenced this issue Apr 5, 2018
@grgustaf
Add support for eval command to support watch variables (jerryscript-…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
anonrig Yagiz Nizipli
GPG key ID: BF30FCDE21EAFABC
Expired
Verified
Learn about vigilant mode
76a9ac2 
…project#21)

Caveat: JerryScript only returns a string representation of the eval
  result, so the patch acts like everything is a string. CDT would
  prefer to get typed information and progressively disclose object
  contents, for example, but this would require JrS enhancements.
Caveat: Ignores script parsing messages during eval, but this may need
  to be restored later to allow debugging inside eval'd code.
Handles only Runtime.evaluateOnCallFrame requests which come
  while the debugger is stopped; ignores Debugger.evaluate calls
  which come while the debugger is resumed. This avoids seeming
  duplication and the need to queue requests.
Add unit tests for nearly all of the added code.

JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected]
This was referenced May 17, 2020
Closed
Closed
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Closed
@Limesss Limesss mentioned this issue May 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chunseoklee @sand1k @ruben-ayrapetyan