Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FromPropertyDescriptor function #70

Closed
kkristof opened this issue May 15, 2015 · 2 comments
Closed

Fix FromPropertyDescriptor function #70

kkristof opened this issue May 15, 2015 · 2 comments
Labels
bug Undesired behaviour ecma core Related to core ECMA functionality
Milestone
Core ECMA features

Comments

@kkristof
Copy link
Contributor

In the function ecma_op_from_property_descriptor the forth section is unreachable.
FromPropertyDescriptor 8.10.4

The function is needed by the Object.getOwnPropertyDescriptor builtin function 15.2.3.4.
@kkristof kkristof added bug Undesired behaviour ecma core Related to core ECMA functionality labels May 15, 2015
@kkristof kkristof added this to the Core ECMA features milestone May 15, 2015
@ruben-ayrapetyan
Copy link
Contributor

Blocks #34

ruben-ayrapetyan added a commit that referenced this issue May 15, 2015
@ruben-ayrapetyan
Fixing ecma_op_from_property_descriptor semantics (type check for inp…
3197fbb 
…ut property descriptor was implemented incorrectly).

Related issue: #70

JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
@ruben-ayrapetyan ruben-ayrapetyan mentioned this issue May 15, 2015
Closed
ruben-ayrapetyan added a commit that referenced this issue May 15, 2015
@ruben-ayrapetyan
Fixing ecma_op_from_property_descriptor semantics (type check for inp…
534f620 
…ut property descriptor was implemented incorrectly).

Related issue: #70

JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
ruben-ayrapetyan added a commit that referenced this issue May 15, 2015
@ruben-ayrapetyan
Fixing ecma_op_from_property_descriptor semantics (type check for inp…
5c76b3f 
…ut property descriptor was implemented incorrectly).

Related issue: #70

JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
@ruben-ayrapetyan
Copy link
Contributor

Fixed. 5c76b3f.
The condition, checking type of property descriptor was incorrect: instead of checking the type of input descriptor, the type of locally created descriptor was checked.

This was referenced May 17, 2020
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Undesired behaviour ecma core Related to core ECMA functionality
Projects
None yet
Milestone
Core ECMA features
Development

No branches or pull requests
2 participants
@kkristof @ruben-ayrapetyan