Add new API function #1161
Add new API function #1161
Conversation
LaszloLango
added
api
| JERRY_ASSERT (!ECMA_IS_VALUE_ERROR (ret_value)); | ||
|
|
||
| return length; | ||
| } /* jerry_get_length */ |
There was a problem hiding this comment.
Why this separate function is needed?
LaszloLango
force-pushed
the
jerry-api-update
branch
from
5bfa712 to
cb10d1d
Compare
| ECMA_FINALIZE (len_value); | ||
|
|
||
| ecma_deref_ecma_string (magic_string_length_p); | ||
| JERRY_ASSERT (!ECMA_IS_VALUE_ERROR (ret_value)); |
There was a problem hiding this comment.
It would be better to handle/free the error if we happen to get one. I don't think hoping that people will play by the rules, and only pass valid arrays to this function is enough.
LaszloLango
force-pushed
the
jerry-api-update
branch
3 times, most recently
from
501b6db to
93e6c5a
Compare
| ecma_value_t len_value = ecma_op_object_get ((jerry_object_t *) object_p, magic_string_length_p); | ||
| ecma_deref_ecma_string (magic_string_length_p); | ||
|
|
||
| ecma_number_t num_var = ecma_number_make_nan (); |
There was a problem hiding this comment.
I don't think an intermediate variable is necessary.
LaszloLango
force-pushed
the
jerry-api-update
branch
from
93e6c5a to
880fad7
Compare
| * | ||
| * Note: | ||
| * Returns 0, if the given parameter is not an array object or | ||
| * cannot retrieve the length. |
There was a problem hiding this comment.
If it is an array you can always retreive the length. It is an unconfigurable data property.
There was a problem hiding this comment.
You can pass any 'const jerry_object_t *object_p' to this function
There was a problem hiding this comment.
I am sorry I wasn't clear. So:
if array -> return length, always
if not -> return 0
So the correct comment is:
Returns 0, if the given parameter is not an array object
|
LGTM after these are fixed |
LaszloLango
force-pushed
the
jerry-api-update
branch
from
880fad7 to
dd43119
Compare
Implemented 'jerry_is_array' and 'jerry_get_array_length' API functions. JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]
LaszloLango
force-pushed
the
jerry-api-update
branch
from
dd43119 to
cfa0c94
Compare
|
LGTM |
1 similar comment
|
LGTM |
Implemented 'jerry_is_array' and 'jerry_get_array_length' API functions.
JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]