Implement Object.keys and Object.getOwnPropertyNames #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galpeter
force-pushed
the
object_keys_props
branch
from
40d358b to
d77440b
Compare
|
@dbatyai, could you take a look? |
| { | ||
| JERRY_ASSERT (obj_p != NULL); | ||
|
|
||
| ecma_completion_value_t new_array = ecma_op_create_array_object (NULL, 0, false); |
There was a problem hiding this comment.
We should probably add an assert here, to make sure new_array is normal.
galpeter
force-pushed
the
object_keys_props
branch
from
d77440b to
4d0e6ed
Compare
|
I've updated the PR. |
21 tasks
|
|
JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
force-pushed
the
object_keys_props
branch
from
4d0e6ed to
5c012a1
Compare
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]