Fixing retrieval of [[Class]] properties for built-in function objects, optimizing memory related to [[Class]] property #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ruben-ayrapetyan
commented
May 28, 2015
ruben-ayrapetyan
commented
- introduced ecma_object_get_class_name interface (the changed implicitly fixed Assertion 'property_p != NULL' failed in ecma_get_internal_property #112);
- removed creation of [[Class]] internal property for types of objects that unambiguously determine the [[Class]] value.
ruben-ayrapetyan
added
bug
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-112
branch
from
9b9dbd6 to
7f42d8a
Compare
…s, optimizing memory related to [[Class]] property. - introduced ecma_object_get_class_name interface; - removed creation of [[Class]] internal property for types of objects that unambiguously determine the [[Class]] value. Related issue: #112 JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-112
branch
from
7f42d8a to
ed14474
Compare
|
Good for me. |
| ECMA_INTERNAL_PROPERTY_BUILT_IN_ID); | ||
| ecma_builtin_id_t builtin_id = (ecma_builtin_id_t) built_in_id_prop_p->u.internal_property.value; | ||
|
|
||
| switch (builtin_id) |
There was a problem hiding this comment.
For me it seems that if the Array built-in is disabled (the CONFIG_ECMA_COMPACT_PROFILE_DISABLE_ARRAY_BUILTIN is defined) then the default case will execute. Am I thinking that correctly, or did I missed something?
There was a problem hiding this comment.
In case the CONFIG_ECMA_COMPACT_PROFILE_DISABLE_ARRAY_BUILTIN is defined,
the Array built-in is disabled, and ECMA_BUILTIN_ID_ARRAY is not included into ecma_builtin_id_t enum.
So, the routine couldn't be called with ECMA_BUILTIN_ID_ARRAY value in the case (it is checked with assertion in the default case).
jerry-core/ecma/builtin-objects/ecma-builtins.inc.h`
#ifndef CONFIG_ECMA_COMPACT_PROFILE_DISABLE_ARRAY_BUILTIN
/* The Array.prototype object (15.4.4) */
BUILTIN (ECMA_BUILTIN_ID_ARRAY_PROTOTYPE,
ECMA_OBJECT_TYPE_ARRAY,
ECMA_MAGIC_STRING_ARRAY_UL,
ECMA_BUILTIN_ID_OBJECT_PROTOTYPE,
true,
true,
array_prototype)
/* The Array object (15.4.1) */
BUILTIN (ECMA_BUILTIN_ID_ARRAY,
ECMA_OBJECT_TYPE_FUNCTION,
ECMA_MAGIC_STRING_ARRAY_UL,
ECMA_BUILTIN_ID_FUNCTION_PROTOTYPE,
true,
true,
array)
#endif /* !CONFIG_ECMA_COMPACT_PROFILE_DISABLE_ARRAY_BUILTIN*/
|
lgtm |
|
Ok, |
|
Merged (da7e9d9). |
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.