Issue #1389 fixed in parser_compute_indicies by resolving local variable hiding. #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktorpi
force-pushed
the
parser_literal_index_fix
branch
from
450940b to
fe5c68b
Compare
LaszloLango
changed the title
LaszloLango
reviewed
Oct 27, 2016
|
|
||
| function x(){} | ||
|
|
||
| 255,256,257,258,259,260,261,262,263,264,265,266,267,268,269,270,271,272,273,274,275,276,277,278,279,280,281,282,283,284,285,286,287,288,289,290,291,292,293,294,295,296,297,298,299,300,301,302,303,304,305,306,307,308,309,310,311,312,313,314,315,316,317,318,319,320,321,322,323,324,325,326,327,328,329,330,331,332,333,334,335,336,337,338,339,340,341,342,343,344,345,346,347,348,349,350,351,352,353,354,355,356,357,358,359,360,361,362,363,364,365,366,367,368,369,370,371,372,373,374,375,376,377,378,379,380,381,382,383,384,385,386,387,388,389,390,391,392,393,394,395,396,397,398,399,400,401,402,403,404,405,406,407,408,409,410,411,412,413,414,415,416,417,418,419,420,421,422,423,424,425,426,427,428,429,430,431,432,433,434,435,436,437,438,439,440,441,442,443,444,445,446,447,448,449,450,451,452,453,454,455,456,457,458,459,460,461,462,463,464,465,466,467,468,469,470,471,472,473,474,475,476,477,478,479,480,481,482,483,484,485,486,487,488,489,490,491,492,493,494,495,496,497,498,499,500,501,502,503,504,505,506,507,508,509, 510, 511, 512 |
There was a problem hiding this comment.
This test different, than that mentioned in #1389 . Is this correct? Are you sure these tests are equal?
There was a problem hiding this comment.
Yes, this simplified test case also works. However please cut the lines after 80 character and the numbers should be strings to avoid number optimizations. So:
"255", "256", ...
or
"a1", "a2", ... would be even better
|
LGTM |
ktorpi
force-pushed
the
parser_literal_index_fix
branch
2 times, most recently
from
e3fd88a to
0a185b4
Compare
…solving local variable hiding. JerryScript-DCO-1.0-Signed-off-by: István Kádár [email protected]
ktorpi
force-pushed
the
parser_literal_index_fix
branch
from
0a185b4 to
0cb191b
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1389 fixed in parser_compute_inicies by resolving local variable hiding.
JerryScript-DCO-1.0-Signed-off-by: István Kádár [email protected]