Make exit behaviour of jerry_fatal flag-dependent
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow-up to #134 as suggested by @ruben-ayrapetyan |
| @@ -1186,6 +1186,15 @@ jerry_get_memory_limits (size_t *out_data_bss_brk_limit_p, /**< out: Jerry's max | |||
| } /* jerry_get_memory_limits */ | |||
|
|
|||
| /** | |||
| * Return whether jerry calls abort on internal failure instead of exit | |||
There was a problem hiding this comment.
@akiss77, could you, please, update the comment to the following?
/**
* Check whether 'abort' should be called instead of 'exit' upon exiting with non-zero exit code.
*
* @return true - if 'abort on fail' flag is set,
* false - otherwise.
*/
* Added new flag `JERRY_FLAG_ABORT_ON_FAIL`. * Added new internal api function `jerry_is_abort_on_fail` to check the status of the flag. * Changed `jerry_fatal` bail-out function to call `abort` when the flag is set and exit code is non-zero (i.e., not only for assertion failures). * Added `--abort-on-fail` command line option to linux and nuttx apps to set the flag. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
|
Rebased and updated according to review |
|
Looks good to me |
|
|
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JERRY_FLAG_ABORT_ON_FAIL.jerry_is_abort_on_failtocheck the status of the flag.
jerry_fatalbail-out function to callabortwhen theflag is set and exit code is non-zero (i.e., not only for
assertion failures).
--abort-on-failcommand line option to linux and nuttxapps to set the flag.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]