-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indentation checks for code inside classes and fix appeared issues. #149
Conversation
Good to me. |
What is the C++ status in Jerry? Is it allowed? |
@LaszloLango, The reason for using one space is to highlight scope of the class (to easily find its boundaries). To my mind, both ways are alright, so we could stick to any of them. |
@sand1k I can live with it. :) We can use one space if I am the only one who doesn't like it. |
@LaszloLango, we discussed this with @egavrin and decided that this indentation is not needed so I'll fix the patch. |
@zherczeg, as we discussed earlier, we should keep existing code "as is" The reason for using C++ in the following components: This code could be written in C, but implementation would be less effective and much more complicated due to manual emulation of inheritance. So we used inheritance and virtual functions in this particular implementation because it simplifies interfaces in comparison to C, while not affecting performance and code size. As we discussed on CC, we consider to use some kind of restricted C++ subset for embedded systems in future. We are preparing a proposal which describes features of C++ that could be effectively used without affecting performance, memory consumption and code size comparing to C. I request you to approve these changes for now. If we would decide to revert C++ usage globally after future investigation, we will rewrite these parts, for example, this could be done during "optimization stage" From my point of view, usage of limited C++ subset would allow us to significantly simplify code base and provide more flexibility in development, while enabling C++-specific optimizations. |
@LaszloLango, I updated the pull request according to your notes. Please, check. |
Fix asserts in test_recordset.cpp. JerryScript-DCO-1.0-Signed-off-by: Andrey Shitov [email protected]
5292a28
to
55b4307
Compare
This commit was LGTM'ed by @LaszloLango and me, but comments are missing now, due to rebasing. |
Add indentation checks for code inside classes and fix appeared issues.
Fix asserts in test_recordset.cpp.