Support labelled statements #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-ayrapetyan
added
normal
parser
| extern void jsp_label_push (jsp_label_t *out_label_p, jsp_label_type_flag_t type_mask, token id); | ||
| extern void jsp_label_rewrite_jumps_and_pop (jsp_label_t *label_p, opcode_counter_t break_tgt_oc); | ||
|
|
||
| extern jsp_label_t* jsp_label_find (jsp_label_type_flag_t type_mask, token id, bool *out_is_simply_jumpable_p); |
There was a problem hiding this comment.
Please align the * to the function name (just like in the parameter list)
ruben-ayrapetyan
force-pushed
the
Ruben-support-labelled-statements
branch
from
8918a89 to
ba55848
Compare
…ment. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
Related issue: #52 JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
ruben-ayrapetyan
force-pushed
the
Ruben-support-labelled-statements
branch
from
ba55848 to
791ef80
Compare
|
@galpeter, I've updated pull request according to your comments. Additionally, I've added two test cases with multiple jumps on same label, and added two commits:
Please, review. |
JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
ruben-ayrapetyan
force-pushed
the
Ruben-support-labelled-statements
branch
from
791ef80 to
2270db9
Compare
|
Good to me. |
|
lgtm |
|
|
3 tasks
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #52