Implement Function.prototype.apply() #163
Conversation
|
|
||
| JERRY_ASSERT (appended_num == len || !ecma_is_completion_value_empty (ret_value)); | ||
|
|
||
| if (len == 0) |
There was a problem hiding this comment.
I think if the ret_value at this point is not empty then we got an exception somewhere and then we should return that instead, no need to invoke the function with ecma_op_function_call.
There was a problem hiding this comment.
Yes, you're right. I've updated this part. Thanks.
| } | ||
| else | ||
| { | ||
| ecma_object_t* obj_p = ecma_get_object_from_value (arg2); |
There was a problem hiding this comment.
* should be at the variable name. Please check the other places to fix also
|
The PR has updated according the review. |
|
lgtm |
| arg1, | ||
| arg_list, | ||
| (ecma_length_t) appended_num); | ||
| } |
There was a problem hiding this comment.
The if (length == 0) part could be removed, as arg_list should be NULL, if length is zero.
|
Do we know why the bot failed? |
|
Looks good to me.
Seems that cause is in some temporary issues that occurred in testing system some time ago, the issues were identified and should have been already fixed now. Could you, please, rebase the pull request on current master? This should also restart the build bot testing for the changes. |
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]
|
Yes, that was the reason. Now passes. Thanks. |
|
|
|
rebased & merged in: 7952b1c |
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]