Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support internal properties in GC mark. #1646

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Support internal properties in GC mark. #1646

merged 1 commit into from
Mar 7, 2017

Conversation

zherczeg
Copy link
Member

@zherczeg zherczeg commented Mar 7, 2017

No description provided.

@LaszloLango
Copy link
Contributor

Is it a bugfix? Could you provide a bit more description?

LaszloLango
LaszloLango approved these changes Mar 7, 2017
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

@zherczeg
Support internal properties in GC mark.
a87586d 
Some internal properties are incorrectly handled as objects and
marked as visited. This memory overwrite caused random crashes
in IoT.js.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
@zherczeg
Copy link
Member Author

zherczeg commented Mar 7, 2017

Done

dbatyai
dbatyai approved these changes Mar 7, 2017
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango added bug Undesired behaviour memory management Related to memory management or garbage collection labels Mar 7, 2017
@LaszloLango
Copy link
Contributor

@zherczeg, thanks. LGTM

@zherczeg zherczeg merged commit 319702c into jerryscript-project:master Mar 7, 2017
@zherczeg zherczeg deleted the gc_fix branch March 7, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloLango LaszloLango LaszloLango approved these changes

@dbatyai dbatyai dbatyai approved these changes

Assignees
No one assigned
Labels
bug Undesired behaviour memory management Related to memory management or garbage collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zherczeg @LaszloLango @dbatyai