Implement parseInt() #167
Closed
Implement parseInt() #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
added
ecma builtins
29 tasks
| int32_t first_nonws = -1; | ||
| for (int i = 0; i < string_len; i++) | ||
| { | ||
| if (!(zt_string_buff[i] == ' ' || zt_string_buff[i] == '\n')) |
There was a problem hiding this comment.
I don't think that these two are enough, the standard says StrWhiteSpaceChar which also contains things like '\t', '\r' etc..
|
I've updated the PR. |
| assert(parseInt("12A3") === 12); | ||
| assert(parseInt("12.34") === 12); | ||
| assert(isNaN(parseInt("AB"))); | ||
|
|
There was a problem hiding this comment.
Maybe we should have test cases where we pass other things like: boolean values, numbers, arrays, empty objects, undefined values for both first and second argument.
|
LGTM |
|
I've added more test cases. |
|
|
||
| /* 6. */ | ||
| ECMA_OP_TO_NUMBER_TRY_CATCH (radix_num, radix, ret_value); | ||
| int32_t r = ecma_number_to_int32 (radix_num); |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]
|
@egavrin, I fixed the style issues. |
|
Good to me. |
|
lgtm |
|
merged: 35840a4 |
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]