Small enhancement of unit tests implementation style and fix of the tests' modules naming style #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-ayrapetyan
force-pushed
the
Ruben-small-enhancements-of-unit-tests
branch
from
e68b4f8 to
acf4edf
Compare
| printf ("TEST_RANDOMIZE: seed is %u\n", seed); \ | ||
| \ | ||
| srand (seed); \ | ||
| } |
There was a problem hiding this comment.
Shouldn't this have the format of: do { ... } while (0) ?
There was a problem hiding this comment.
Thanks for the note. I've updated pull request.
ruben-ayrapetyan
force-pushed
the
Ruben-small-enhancements-of-unit-tests
branch
2 times, most recently
from
60dc0d0 to
6ca37ea
Compare
|
Good to me. |
|
Looks good to me. |
|
@ruben-ayrapetyan |
…tests' modules naming style. - introducing TEST_RANDOMIZE macro for randomization of source data used in unit tests; - replacing assert with JERRY_ASSERT; - renaming test_* to test-*. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
ruben-ayrapetyan
force-pushed
the
Ruben-small-enhancements-of-unit-tests
branch
from
6ca37ea to
57c6c37
Compare
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assertwithJERRY_ASSERT;