Update API for invocation of functions and constructors #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-181
branch
from
9c84ba5 to
5da7d7f
Compare
|
Good to me. |
|
@galpeter, could you review, please? |
| jerry_api_convert_ecma_value_to_api_value (retval_p, type_error_value); | ||
|
|
||
| ecma_deref_object (type_error_obj_p); | ||
| } /* jerry_api_throw_type_error */ |
There was a problem hiding this comment.
This comment does not match the name of the method.
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-181
branch
from
5da7d7f to
f625f1e
Compare
|
@galpeter, thank you for note. |
|
@ruben-ayrapetyan, looks good to me. |
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-181
branch
from
f625f1e to
17c7c2f
Compare
|
|
With the change, if exception is thrown in `jerry_api_function_call` and `jerry_api_construct_object`, the exception object is returned to the caller. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-181
branch
from
17c7c2f to
5315677
Compare
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change, if exception is thrown in
jerry_api_function_callandjerry_api_construct_object, the exception object is returned to the caller.Related issue: #181