Implement String.prototype.trim() #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egavrin
added
ecma builtins
|
|
||
| new_len = len - prefix - postfix; | ||
|
|
||
| MEM_DEFINE_LOCAL_ARRAY (new_str_buffer, new_len+1, ecma_char_t); |
| @@ -554,7 +555,62 @@ ecma_builtin_string_prototype_object_to_locale_upper_case (ecma_value_t this_arg | |||
| static ecma_completion_value_t | |||
| ecma_builtin_string_prototype_object_trim (ecma_value_t this_arg) /**< this argument */ | |||
There was a problem hiding this comment.
Add tests for trim, please.
Like from here:
var orig = ' foo ';
console.log(orig.trim());
var orig = 'foo ';
console.log(orig.trim()); // 'foo'
lvidacs
force-pushed
the
string_prototype_trim
branch
from
fa5b9a5 to
722faf8
Compare
|
Thanks for the review, the patch is updated and tests are added. |
25 tasks
29 tasks
| @@ -14,6 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| #include <ctype.h> | |||
There was a problem hiding this comment.
AFAIK: we usually use the jrt-libc-include.h and not directly the ctype.h/other libc headers.
lvidacs
force-pushed
the
string_prototype_trim
branch
from
eddb47c to
c4c0437
Compare
| ecma_op_to_string (this_arg), | ||
| ret_value); | ||
|
|
||
| if (ecma_is_completion_value_empty (ret_value)) |
There was a problem hiding this comment.
No need for this check as inside the ECMA_TRY_CATCH the ret_value is an empty value.
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs [email protected]
lvidacs
force-pushed
the
string_prototype_trim
branch
from
c4c0437 to
2c93ffd
Compare
| prefix++; | ||
| } | ||
|
|
||
| while (postfix < len - prefix && isspace (original_zt_str_p[len-postfix-1])) |
|
Good to me after fixing. |
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs [email protected]
lvidacs
force-pushed
the
string_prototype_trim
branch
from
2c93ffd to
58f49ca
Compare
|
Thanks for the reviews, the patch is updated. |
|
if @galpeter is OK, |
|
looks better, lgtm |
|
Rebased & squased & merged: caa1617 |
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs [email protected]