Implement Date object helper functions #199
Conversation
LaszloLango
added
ecma builtins
| @@ -0,0 +1,501 @@ | |||
| /* Copyright 2014-2015 Samsung Electronics Co., Ltd. | |||
|
Otherwise lgtm. |
| @@ -0,0 +1,140 @@ | |||
|
|
|||
There was a problem hiding this comment.
Could you, please, commit addition of ./third-party/fdlibm/* separately.
| #include "ecma-helpers.h" | ||
| #include "fdlibm-math.h" | ||
|
|
||
| #ifndef CONFIG_ECMA_COMPACT_PROFILE_DISABLE_DATE_BUILTIN |
There was a problem hiding this comment.
Are helpers from the module supposed to be used somewhere outside of jerry-core/ecma/builtin-objects/?
There was a problem hiding this comment.
No, maybe we wouldn't use them anywhere outside of builtins. So should I remove this guard?
There was a problem hiding this comment.
Please, move them to jerry-core/ecma/builtin-objects (maybe to ecma-builtin-helpers.cpp, as the helpers would be used for implementation of both Date and Date.prototype built-ins).
|
Please, split PR on two commits: Add fdlib and Date logic. |
szledan
force-pushed
the
date_helpers
branch
2 times, most recently
from
d8fcbbb to
3e960da
Compare
|
This PR depends on #223. |
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan [email protected]
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan [email protected]
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan [email protected]
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan [email protected]
| ecma_date_daylight_saving_ta (ecma_number_t __attr_unused___ time) /**< time value */ | ||
| { | ||
| JERRY_ASSERT (!ecma_number_is_nan (time)); | ||
| JERRY_UNIMPLEMENTED ("The ecma_date_daylight_saving_ta is not implemented yet."); |
There was a problem hiding this comment.
Minor note: there is no need to the function name to the unimplemented comment as the macro will print out the file name, function name and line number.
Add comments to the time range defines JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan [email protected]
|
Hi, I have updated the patch. Could you take a look? ( @kkristof ) |
|
lgtm |
|
Looks good to me |
|
Rebased & merged: 07148d3 |
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan [email protected]