Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerequisites preparation fix for behind firewall. #20

Merged
merged 1 commit into from
May 8, 2015
Merged

Prerequisites preparation fix for behind firewall. #20

merged 1 commit into from
May 8, 2015

Conversation

seanshpark
Copy link
Contributor

JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]

@seanshpark
Copy link
Contributor Author

added a pull request for #16

@@ -211,7 +211,7 @@ function setup_vera() {
return 0
fi

wget -O "$TMP_DIR/$NAME.tar.gz" "$URL" || fail_msg "$FAIL_MSG. Cannot download '$URL' archive."
wget --no-check-certificate -O "$TMP_DIR/$NAME.tar.gz" "$URL" || fail_msg "$FAIL_MSG. Cannot download '$URL' archive."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two more wget commands in the script.
Maybe, --no-check-certificate is necessary for them too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as with my current environment vera only rejects. it will be better to add all. I'll check.

JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]
@seanshpark
Copy link
Contributor Author

it's ok to add all three

@ruben-ayrapetyan ruben-ayrapetyan merged commit d0f30f5 into jerryscript-project:master May 8, 2015
sand1k added a commit to sand1k/jerryscript that referenced this pull request Dec 3, 2015
grgustaf added a commit to grgustaf/jerryscript that referenced this pull request Apr 4, 2018
* replace concatenation with template strings
* fix output constants to match JerryScript debugger
* replace a needlessly named function with an arrow function

JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants