[Bugfix] free error in typearray set value routine #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
reviewed
Dec 12, 2017
| @@ -897,6 +898,11 @@ ecma_op_typedarray_set_index_prop (ecma_object_t *obj_p, /**< a TypedArray objec | |||
| return true; | |||
| } | |||
|
|
|||
| if (ECMA_IS_VALUE_ERROR (error)) | |||
There was a problem hiding this comment.
What about merging the two if statements like this?
if (ECMA_IS_VALUE_ERROR (error))
{
ecma_free_value (JERRY_CONTEXT (error_value));
return false;
}
JERRY_ASSERT (ecma_is_value_empty (error));
return true;
Issue: jerryscript-project#2143 JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang [email protected]
|
lgtm (the failed check is the mbed build which was moved to allowed failure group) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2143
JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang [email protected]