Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer size in Number.prototype.toFixed() #225

Closed
wants to merge 1 commit into from
Closed

Fix buffer size in Number.prototype.toFixed() #225

wants to merge 1 commit into from

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented Jun 22, 2015

We did not allocate enough space for '\0' and sign characters. Fixed this, and added assert to make sure we don't write outside of the buffer.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]

@dbatyai
Fix buffer size in Number.prototype.toFixed()
45fb067 
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]
@dbatyai dbatyai added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels Jun 22, 2015
@ruben-ayrapetyan
Copy link
Contributor

Looks good to me.

@egavrin
Copy link
Contributor

egavrin commented Jun 22, 2015

make push

@egavrin egavrin added this to the ECMA builtins milestone Jun 22, 2015
@kkristof
Copy link
Contributor

lgtm

@dbatyai
Copy link
Member Author

dbatyai commented Jun 23, 2015

merged: 7d3bb85

@dbatyai dbatyai closed this Jun 23, 2015
@dbatyai dbatyai deleted the number_proto_tofixed_buff_size branch June 24, 2015 10:56
@zherczeg zherczeg mentioned this pull request Jul 20, 2016
Closed
This was referenced May 17, 2020
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dbatyai dbatyai

Labels
bug Undesired behaviour ecma builtins Related to ECMA built-in routines
Projects
None yet
Milestone
ECMA builtins
Development

Successfully merging this pull request may close these issues.
4 participants
@dbatyai @ruben-ayrapetyan @egavrin @kkristof