Improve jerry_is_feature_enabled with object availability information #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
requested changes
Mar 23, 2018
docs/02.API-REFERENCE.md
Outdated
| @@ -53,6 +53,11 @@ Possible compile time enabled feature types: | |||
| - JERRY_FEATURE_SNAPSHOT_EXEC - executing snapshot files | |||
| - JERRY_FEATURE_DEBUGGER - debugging | |||
| - JERRY_FEATURE_VM_EXEC_STOP - stopping ECMAScript execution | |||
| - JERRY_FEATURE_JSON - JSON functions | |||
| - JERRY_FEATURE_PROMISE - promise builtin | |||
docs/02.API-REFERENCE.md
Outdated
| - JERRY_FEATURE_JSON - JSON functions | ||
| - JERRY_FEATURE_PROMISE - promise builtin | ||
| - JERRY_FEATURE_TYPEDARRAY - Typedarray builtin | ||
| - JERRY_FEATURE_DATE - Date builtin |
robertsipka
reviewed
Mar 23, 2018
jerry-core/api/jerry.c
Outdated
| || feature == JERRY_FEATURE_DATE | ||
| #endif /* !CONFIG_DISABLE_DATE_BUILTIN */ | ||
| #ifndef CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN | ||
| || feature == JERRY_FEATURE_REGEX |
There was a problem hiding this comment.
I think this is not JERRY_FEATURE_REGEX. Please update the name of the macro to CONFIG_DISABLE_REGEXP_BUILTIN
ZsoltRaduska
force-pushed
the
improveJerryIsFeatureEnabled
branch
from
df6c9c0 to
39ca9b0
Compare
zherczeg
requested changes
Mar 27, 2018
docs/02.API-REFERENCE.md
Outdated
| @@ -53,6 +53,11 @@ Possible compile time enabled feature types: | |||
| - JERRY_FEATURE_SNAPSHOT_EXEC - executing snapshot files | |||
| - JERRY_FEATURE_DEBUGGER - debugging | |||
| - JERRY_FEATURE_VM_EXEC_STOP - stopping ECMAScript execution | |||
| - JERRY_FEATURE_JSON - JSON functions | |||
docs/02.API-REFERENCE.md
Outdated
| @@ -53,6 +53,11 @@ Possible compile time enabled feature types: | |||
| - JERRY_FEATURE_SNAPSHOT_EXEC - executing snapshot files | |||
| - JERRY_FEATURE_DEBUGGER - debugging | |||
| - JERRY_FEATURE_VM_EXEC_STOP - stopping ECMAScript execution | |||
| - JERRY_FEATURE_JSON - JSON functions | |||
| - JERRY_FEATURE_PROMISE - promise builtin | |||
There was a problem hiding this comment.
promise support
also change builtin -> support everywhere
| JERRY_FEATURE_PROMISE, /**< promise builtin */ | ||
| JERRY_FEATURE_TYPEDARRAY, /**< Typedarray builtin */ | ||
| JERRY_FEATURE_DATE, /**< Date builtin */ | ||
| JERRY_FEATURE_REGEX, /**< Regex builtin */ |
ZsoltRaduska
force-pushed
the
improveJerryIsFeatureEnabled
branch
from
39ca9b0 to
d001b25
Compare
|
LGTM (informally) |
LaszloLango
requested changes
Apr 3, 2018
| JERRY_FEATURE_PROMISE, /**< promise support */ | ||
| JERRY_FEATURE_TYPEDARRAY, /**< Typedarray support */ | ||
| JERRY_FEATURE_DATE, /**< Date support */ | ||
| JERRY_FEATURE_REGEX, /**< Regex support */ |
There was a problem hiding this comment.
The standard calls it RegExp and not Regex, so please rename to be consistent. http://www.ecma-international.org/ecma-262/5.1/index.html#sec-15.10
JERRY_FEATURE_REGEXP, /**< RegExp support */
docs/02.API-REFERENCE.md
Outdated
| - JERRY_FEATURE_PROMISE - promise support | ||
| - JERRY_FEATURE_TYPEDARRAY - Typedarray support | ||
| - JERRY_FEATURE_DATE - Date support | ||
| - JERRY_FEATURE_REGEX - Regex support |
There was a problem hiding this comment.
JERRY_FEATURE_REGEXP - RegExp support
jerry-core/api/jerry.c
Outdated
| || feature == JERRY_FEATURE_DATE | ||
| #endif /* !CONFIG_DISABLE_DATE_BUILTIN */ | ||
| #ifndef CONFIG_DISABLE_REGEXP_BUILTIN | ||
| || feature == JERRY_FEATURE_REGEX |
JerryScript-DCO-1.0-Signed-off-by: Zsolt Raduska [email protected]
ZsoltRaduska
force-pushed
the
improveJerryIsFeatureEnabled
branch
from
d001b25 to
9c5da0d
Compare
martijnthe
pushed a commit
to martijnthe/jerryscript
that referenced
this pull request
Apr 6, 2018
* Add the ability to throw an error to python debugger (jerryscript-project#2188) This patch makes it possible to throw an error from the python debugger client using the `throw` command. JerryScript-DCO-1.0-Signed-off-by: Daniel Balla [email protected] * Fix typo and redundant text in the documentation. (jerryscript-project#2260) JerryScript-DCO-1.0-Signed-off-by: Daniel Vince [email protected] * Fix accessing the contents of a direct string (jerryscript-project#2261) In the `ecma_string_get_chars` method the contents of a direct string is accessed incorrectly. It tries to extract the magic string id from the string pointer but the direct string does not need this step. JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected] * Remove websocket message macros in debugger (jerryscript-project#2262) JERRY_DEBUGGER_INIT_SEND_MESSAGE JERRY_DEBUGGER_SET_SEND_MESSAGE_SIZE JERRY_DEBUGGER_SET_SEND_MESSAGE_SIZE_FROM_TYPE JerryScript-DCO-1.0-Signed-off-by: Jimmy Huang [email protected] * Remove TARGET_HOST macros (jerryscript-project#2264) Remove TARGET_HOST defines from the jerry-libc module and replace with compiler provided macros. JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos [email protected] * Fix bug in stringToCesu8 conversion for 0x7ff (jerryscript-project#2267) JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected] * Add ecma_free_all_enqueued_jobs function (jerryscript-project#2265) This function releases any remaining promise job that wasn't completed. Also added this function to `jerry_cleanup ()`, therefore it will be automatically run. JerryScript-DCO-1.0-Signed-off-by: Daniel Balla [email protected] * Improve jerry_is_feature_enabled with object availability information (jerryscript-project#2250) JerryScript-DCO-1.0-Signed-off-by: Zsolt Raduska [email protected] * Add json parse and stringify function to jerryscript c api (jerryscript-project#2243) JerryScript-DCO-1.0-Signed-off-by: Zsolt Raduska [email protected] * Simplify debugger-ws.h (jerryscript-project#2266) Remove several macros and types from it. This change simplifies the external debugger interface. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected] * Add finalize_cb to jerry_context_data_manager_t (jerryscript-project#2269) This patch adds a new finalize_cb callback to jerry_context_data_manager_t. The callback is run as the very last thing in jerry_cleanup, after the VM has been torn down entirely. There was already the deinit_cb, which is run while the VM is still in the process of being torn down. The reason the deinit_cb is not always sufficient is that there may still be objects alive (because they still being referenced) that have native pointers associated with the context manager that is being deinit'ed. As a result, the free_cb's for those objects can get called *after* the associated context manager's deinit_cb is run. This makes cleanup of manager state that is depended on by the live objects impossible to do in the deinit_cb. That type of cleanup can only be done when all values have been torn down completely. JerryScript-DCO-1.0-Signed-off-by: Martijn The [email protected] * Rework snapshot generation API. (jerryscript-project#2259) Also remove eval context support. It provides no practical advantage. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected] * Implement the ES2015 version of Object.getPrototypeOf and add a test file for it (jerryscript-project#2256) JerryScript-DCO-1.0-Signed-off-by: Peter Marki [email protected] * Move DevTools integration code into jerry-client-ts subdir JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected] * Fix some things to match the new directory for TS code JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected]
jimmy-huang
pushed a commit
to jimmy-huang/jerryscript
that referenced
this pull request
May 8, 2018
…jerryscript-project#2250) JerryScript-DCO-1.0-Signed-off-by: Zsolt Raduska [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Zsolt Raduska [email protected]