Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented [[HasProperty]] for Objects. #23

Closed
wants to merge 1 commit into from
Closed

Implemented [[HasProperty]] for Objects. #23

wants to merge 1 commit into from

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented May 7, 2015

This will be required by Array.prototype functions.

JerryScript-DCO-1.0-Signed-off-by: Daniel Batyai [email protected]

JerryScript-DCO-1.0-Signed-off-by: Daniel Batyai [email protected]
ecma_string_t *property_name_p) /**< property name */
{
// 1.
ecma_property_t *desc_p = ecma_op_general_object_get_own_property (obj_p, property_name_p);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dániel!

Why the implementation of [[HasProperty]] for Arguments object is different from implementation for other object types?

@dbatyai
Copy link
Member Author

dbatyai commented May 8, 2015

Hi Ruben!

Thanks for clarifying, I didn't notice this.
I don't think it is necessary to change the current practice, I'll update my other requests and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants