Implement String.prototype.substring() #244
Closed
+232
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| arg2, | ||
| ret_value); | ||
|
|
||
| if (ecma_is_completion_value_empty (ret_value)) |
There was a problem hiding this comment.
at this point the ret_value is empty, no need for the check
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs [email protected]
lvidacs
force-pushed
the
string_prototype_substring
branch
from
f965609 to
69a2739
Compare
|
Right, the patch is updated, thanks. |
25 tasks
| arg2, | ||
| ret_value); | ||
|
|
||
| if (ecma_number_is_nan (end_num) || ecma_number_is_negative (end_num)) |
There was a problem hiding this comment.
This if-else block seems identical with the one above, could we have maybe a helper method for it? Another thing: there is the ecma_builtin_helper_array_index_normalize function which does something like this, could you check if that could be used?
| /* 1 */ | ||
| ECMA_TRY_CATCH (check_coercible_val, | ||
| ecma_op_check_object_coercible (this_arg), | ||
| ret_value); |
There was a problem hiding this comment.
Is this implicitly changes the this value?
lvidacs
force-pushed
the
string_prototype_substring
branch
from
69a2739 to
5a32c27
Compare
|
Continued in PR #318 |
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs [email protected]