Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realloc function to jmem #2619

Closed

Conversation

mmatyas
Copy link
Contributor

@mmatyas mmatyas commented Nov 26, 2018

This patch extends jmem functionality by adding a realloc function.
This opens up other paths of optimization which can result in smaller
peak memory usage and faster execution times, due to not having to
duplicate memory when we need to extend blocks.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]

This patch extends jmem functionality by adding a realloc function.
This opens up other paths of optimization which can result in smaller
peak memory usage and faster execution times, due to not having to
duplicate memory when we need to extend blocks.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]
@mmatyas
Copy link
Contributor Author

mmatyas commented Nov 26, 2018

The feature this patch implements will be used for the string construction buffer optimizations -- see #2617.

@akosthekiss
Copy link
Member

PR author and commit author are quite different. Interestingly, CI is not unhappy about that. Should this get approved and landed (via squash&merge on the web interface), I'm not completely sure what will happen. If I recall correctly, GH will rewrite at least the committer (making it the person who has pushed the green button). Whether the author gets also rewritten, I'm not sure. But either @mmatyas or @dbatyai will lose credit. Just sayin'.

@DanielBallaSZTE
Copy link

DanielBallaSZTE commented Nov 26, 2018

As far as I know the last line of the commit should be the sign-off with the author of the commit.
A good feature to use in this case is the co-author feature.
You can read more about it here:
https://help.github.com/articles/creating-a-commit-with-multiple-authors/

@akosthekiss
Copy link
Member

@DanielBallaSZTE That looks like a nice feature. Does it work with our DCO signoff requirement? (It must be the last line of the commit message. Github co-author markups must also be on the last line(s) of the commit message. Do these conflict?)

@DanielBallaSZTE
Copy link

@akosthekiss
I used it several times, and put it right before the sign-off message. It didn't conflict, and marked @rerobika as the co-author in the commit.
(Reference: #2514)

@zherczeg
Copy link
Member

How this is compatible with system allocator? I am not sure all embedded systems has realloc.

@akosthekiss
Copy link
Member

@DanielBallaSZTE I cannot find the referenced commit among @rerobika 's contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants