Preparations for support of non-nuttx externally built targets #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # stdlib.h is just one of standard headers that should be included in a standard-compliant libc | ||
| if(EXISTS "${EXTERNAL_LIB_INTERFACE}/stdlib.h") | ||
| set(USE_JERRY_LIBC FALSE) | ||
| set(INCLUDE_LIBC_INTERFACE ${EXTERNAL_LIB_INTERFACE}) |
There was a problem hiding this comment.
What if more than one external library provides stdlib.h? Maybe we should signal an error message in this case?
There was a problem hiding this comment.
Ok. I'll add the check that would terminate build in the case: it seems that if more than one external library provides stdlib.h, we would have include path conflicts anyway.
ruben-ayrapetyan
force-pushed
the
several_external_libraries
branch
from
2c535f4 to
1431251
Compare
ruben-ayrapetyan
changed the title
…n libc. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
…from Nuttx OS. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
ruben-ayrapetyan
force-pushed
the
several_external_libraries
branch
from
1431251 to
2852d93
Compare
|
LGTM. |
sand1k
added a commit
to sand1k/jerryscript
that referenced
this pull request
Dec 8, 2015
…iments-dev Experiments dev
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to specify include interfaces for more than one external library (for external builds).