Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syntax check for return from global scope/eval. #290

Merged
merged 1 commit into from
Jul 2, 2015
Merged

Add syntax check for return from global scope/eval. #290

merged 1 commit into from
Jul 2, 2015

Conversation

egavrin
Copy link
Contributor

@egavrin egavrin commented Jul 1, 2015

Related issue: #129

JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]

@egavrin egavrin added bug Undesired behaviour parser Related to the JavaScript parser labels Jul 1, 2015
@egavrin egavrin added this to the Core ECMA features milestone Jul 1, 2015
@ruben-ayrapetyan
Copy link
Contributor

Looks good to me.

@ruben-ayrapetyan
Copy link
Contributor

Could you, please, add "Related issue:" to commit message?

@egavrin egavrin changed the title `Add syntax check for return from global scope/eval. Add syntax check for return from global scope/eval. Jul 1, 2015
@egavrin egavrin force-pushed the fix-issue-129-dev branch from 92f2c29 to e1a3944 Compare July 1, 2015 16:59
@egavrin
Copy link
Contributor Author

egavrin commented Jul 1, 2015

@ruben-ayrapetyan done

@ruben-ayrapetyan
Copy link
Contributor

@egavrin, thank you!

@egavrin egavrin assigned galpeter and unassigned egavrin Jul 1, 2015
@galpeter
Copy link
Contributor

galpeter commented Jul 2, 2015

looks good to me

@galpeter galpeter removed their assignment Jul 2, 2015
@zherczeg
Copy link
Member

zherczeg commented Jul 2, 2015

lgtm

@egavrin
Add syntax check for return from global scope/eval.
69fe619 
Related issue: #129

JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]
@egavrin egavrin force-pushed the fix-issue-129-dev branch from e1a3944 to 69fe619 Compare July 2, 2015 16:12
@egavrin egavrin merged commit 69fe619 into master Jul 2, 2015
@egavrin egavrin deleted the fix-issue-129-dev branch July 3, 2015 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Undesired behaviour parser Related to the JavaScript parser
Projects
None yet
Milestone
Core ECMA features
Development

Successfully merging this pull request may close these issues.
4 participants
@egavrin @ruben-ayrapetyan @galpeter @zherczeg