Implement Object.prototype.toLocaleString #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
| ecma_free_completion_value (obj_this); | ||
|
|
||
| ecma_string_t *to_string_magic_string_p = ecma_get_magic_string (ECMA_MAGIC_STRING_TO_STRING_UL); | ||
| ecma_completion_value_t to_string_prop_ret = ecma_op_object_get (obj_p, to_string_magic_string_p); |
There was a problem hiding this comment.
The obj_p reference cannot be used here, because it was released on line 163.
galpeter
force-pushed
the
object_prototype_tolocalestring
branch
2 times, most recently
from
b8d1d1d to
f9109ba
Compare
|
I've updated the pull request. |
galpeter
force-pushed
the
object_prototype_tolocalestring
branch
from
f9109ba to
996bb5a
Compare
| ecma_object_t *to_string_func_obj_p = ecma_get_object_from_value (to_string_val); | ||
| return_value = ecma_op_function_call (to_string_func_obj_p, this_arg, NULL, 0); | ||
| } | ||
| ECMA_FINALIZE (to_string_val) |
There was a problem hiding this comment.
Please, add semicolon here and below.
|
Fix semicolons and |
galpeter
force-pushed
the
object_prototype_tolocalestring
branch
from
996bb5a to
5cce2a0
Compare
JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
force-pushed
the
object_prototype_tolocalestring
branch
from
5cce2a0 to
7954df3
Compare
ruben-ayrapetyan
added a commit
to sand1k/jerryscript
that referenced
this pull request
Dec 15, 2015
…iments-dev Experiments dev
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]