Implement Object.property.hasOwnProperty

[galpeter]

JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]

[egavrin]

Please, add semicolon after statement.

[galpeter]

I've updated the pull request.

[egavrin]

Looks good. make push

[galpeter]

I've got a forked repository with that the make push will not work as expected. Can't I just push the Merge pull request button?

[ruben-ayrapetyan]

@galpeter , please do the following on the repository:

git checkout -b galpeter-object_prototype_hasownproperty master
git pull https://github.com/galpeter/jerryscript.git object_prototype_hasownproperty
git rebase master
git checkout master
git merge --ff-only galpeter-object_prototype_hasownproperty
make push

[ruben-ayrapetyan]

Looks like the sequence could be put into some script in tools directory.
Evgeny, what do you think about the idea?

[egavrin]

@ruben-ayrapetyan I think this is not needed, wiki page for that would be OK.

[galpeter]

merged: 6c4e988

[galpeter]

@ruben-ayrapetyan, @egavrin

Using the rebase during the merge, will result a different hash, thus the after pushing the merge (well rebase in terms) the github will not detect that the given pull request was merged and the person who did the merge needs to go to the issue and close it manually (and probably enter the link to the merge hash). This is a waste of time IMHO.

[ruben-ayrapetyan]

@galpeter , try to use push -f for updating your branch.
We performed this for pull requests, and they were marked as merged automatically.

[galpeter]

@ruben, sure I can do that but I need to do it on the other (forked) repo (as this is currently a forked pull-request) and it's a huge waste of time to rebase the branch first, upload it, then go to the other repo pull down the, perform again the steps described above (hope that the upstream didn't had any new commits since then, if it did have then the rebase will change the hash) and do the make push (and again, hope that during the make push's precommit check there was no new commits in the master).

[ruben-ayrapetyan]

@galpeter ,
Yes, it really seems to be inconvenient in case of forked repository.
Hope, soon we would use branch model, and the procedure would be ok.
I used it for all of my pull requests without any issues rebasing branch to master.